Bug#556248: workaround...

January 10th, 2010 - 04:50 am ET by Joseph Rawson | Report spam
boundary="Boundary-01=_vDaSLW/ylgnxI2G"



I was hoping that this problem would've been fixed by now, but since I got
tired of being unable to run debuild, I tried to figure out what happened.

I compared the debuild from lenny to find what change had caused the problem,
and I just reverted that part of debuild back to the way it was done in lenny.
I attached a simple patch that I've been using successfully (so far).

I'm sorry that I can't be more help, but I'm absolutely dimwitted when it
comes to messing with perl.

Thanks:
Joseph Rawson

name="debuild.diff"
filename="debuild.diff"

./scripts/debuild.pl 2010-01-02 21:20:42.000000000 -0600
+++ /usr/local/bin/debuild-hacked 2010-01-10 03:25:30.000000000 -0600
@@ -276,7 +276,7 @@
foreach my $var ($dpkg_opts_var, $lintian_opts_var) {
$shell_cmd .= "eval set -- \$$var;";
$shell_cmd .= "echo \">>> $var BEGIN <<<\";";
- $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift; done;' . "";
+ $shell_cmd .= 'while [ $# -gt 0 ]; do echo $1; shift; done;' . "";
$shell_cmd .= "echo \">>> $var END <<<\";";
}
# Not totally efficient, but never mind







To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
email Follow the discussionReplies 5 repliesReplies Make a reply

Similar topics

Replies

#1 Adam D. Barratt
January 10th, 2010 - 05:50 am ET | Report spam
Hi,

On Sun, January 10, 2010 09:42, Joseph Rawson wrote:
I was hoping that this problem would've been fixed by now, but since I got
tired of being unable to run debuild, I tried to figure out what happened.

I compared the debuild from lenny to find what change had caused the
problem,
and I just reverted that part of debuild back to the way it was done in
lenny.
I attached a simple patch that I've been using successfully (so far).



- $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift;
done;' . "";
+ $shell_cmd .= 'while [ $# -gt 0 ]; do echo $1; shift; done;' . "";

Unfortunately, that also reintroduces another bug, which is what the
change was made to fix in the first place, namely that the use of echo
means that the dpkg / lintian options parameters can't contain any string
which a valid option to echo (e.g. "-e").

Regards,

Adam




To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#2 Joseph Rawson
January 10th, 2010 - 11:50 am ET | Report spam

On Sunday 10 January 2010 04:40:08 Adam D. Barratt wrote:
Hi,

On Sun, January 10, 2010 09:42, Joseph Rawson wrote:
> I was hoping that this problem would've been fixed by now, but since I
> got tired of being unable to run debuild, I tried to figure out what
> happened.
>
> I compared the debuild from lenny to find what change had caused the
> problem,
> and I just reverted that part of debuild back to the way it was done in
> lenny.
> I attached a simple patch that I've been using successfully (so far).

- $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift;
done;' . "";
+ $shell_cmd .= 'while [ $# -gt 0 ]; do echo $1; shift; done;' .
"";

Unfortunately, that also reintroduces another bug, which is what the
change was made to fix in the first place, namely that the use of echo
means that the dpkg / lintian options parameters can't contain any string
which a valid option to echo (e.g. "-e").

Regards,

Adam



I figured that the line was put there for a reason. I just didn't know what
it was. For me, the old line does what I want it to, while the new one
doesn't. Now that I have looked more closely at this, the code in question
isn't really perl, as much as shell code, so I will ponder another solution.

Here is another workaround, that works for me, and this may be something that
can best be fixed in the documentation.

in ~/.devscripts:
old line:
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-m'Joseph Rawson (new email)
' -sa"

new line:
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-m\'Joseph\ Rawson\ \(new email\)\
\' -sa"

Escaping the single quotes, the spaces and the parentheses seems to work just
fine with the new code.

I think that this solution might be better.

Thanks:
Joseph Rawson






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#3 Joseph Rawson
January 10th, 2010 - 12:00 pm ET | Report spam

On Sunday 10 January 2010 10:22:58 Joseph Rawson wrote:
<snip>
new line:
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-m\'Joseph\ Rawson\ \(new email\)\
\' -sa"

Escaping the single quotes, the spaces and the parentheses seems to work
just fine with the new code.

I think that this solution might be better.



incomplete...
the new line should be
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-m\'Joseph\ Rawson\ \(new\ email\)\
\' -sa"

spaces seem to get munged together without being escaped

sorry about that


Thanks:
Joseph Rawson






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#4 James Vega
January 10th, 2010 - 08:40 pm ET | Report spam

On Sun, Jan 10, 2010 at 10:22:58AM -0600, Joseph Rawson wrote:
On Sunday 10 January 2010 04:40:08 Adam D. Barratt wrote:
> On Sun, January 10, 2010 09:42, Joseph Rawson wrote:
> > I was hoping that this problem would've been fixed by now, but since I
> > got tired of being unable to run debuild, I tried to figure out what
> > happened.
> >
> > I compared the debuild from lenny to find what change had caused the
> > problem,
> > and I just reverted that part of debuild back to the way it was done in
> > lenny.
> > I attached a simple patch that I've been using successfully (so far).
>
> - $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift;
> done;' . "";
> + $shell_cmd .= 'while [ $# -gt 0 ]; do echo $1; shift; done;' .
> "";



Raphael Geissert pointed out on IRC that quoting the $1 should fix the
problem. Could you try that out, Joseph?

- $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift; done;' . "";
+ $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" "$1"; shift; done;' . "";

James
GPG Key: 1024D/61326D40 2003-09-02 James Vega






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#5 Joseph Rawson
January 11th, 2010 - 02:00 am ET | Report spam

On Sunday 10 January 2010 19:26:24 James Vega wrote:
On Sun, Jan 10, 2010 at 10:22:58AM -0600, Joseph Rawson wrote:
> On Sunday 10 January 2010 04:40:08 Adam D. Barratt wrote:
> > On Sun, January 10, 2010 09:42, Joseph Rawson wrote:
> > > I was hoping that this problem would've been fixed by now, but since
> > > I got tired of being unable to run debuild, I tried to figure out
> > > what happened.
> > >
> > > I compared the debuild from lenny to find what change had caused the
> > > problem,
> > > and I just reverted that part of debuild back to the way it was done
> > > in lenny.
> > > I attached a simple patch that I've been using successfully (so far).
> >
> > - $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift;
> > done;' . "";
> > + $shell_cmd .= 'while [ $# -gt 0 ]; do echo $1; shift; done;' .
> > "";

Raphael Geissert pointed out on IRC that quoting the $1 should fix the
problem. Could you try that out, Joseph?

- $shell_cmd .= 'while [ $# -gt 0 ]; do printf "%s" $1; shift;
done;' . ""; + $shell_cmd .= 'while [ $# -gt 0 ]; do printf
"%s" "$1"; shift; done;' . "";



Yes, this solution works well!
Thanks for taking the time to help me. :)

Thanks:
Joseph Rawson






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
email Follow the discussion Replies Reply to this message
Help Create a new topicReplies Make a reply
Search Make your own search