Bug#664724: rrdtool: diff for NMU version 1.4.7-1.2

July 29th, 2012 - 11:50 am ET by gregor herrmann | Report spam



tags 664724 + patch
tags 664724 + pending
thanks

Dear maintainer,

I've prepared an NMU for rrdtool (versioned as 1.4.7-1.2) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.

Regards.

.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Tom Waits: Lullaby


diff -u rrdtool-1.4.7/debian/rules rrdtool-1.4.7/debian/rules
rrdtool-1.4.7/debian/rules
+++ rrdtool-1.4.7/debian/rules
@@ -123,7 +123,7 @@

# clean what the Makefiles do not clean ...
rm -rf bindings/perl-piped/blib bindings/perl-shared/blib \
- bindings/perl-piped/Makefile.old bindings/perl-shared/Makefile.old
+ bindings/perl-piped/Makefile.old bindings/perl-shared/Makefile.old bindings/perl-shared/MYMETA.yml
rm -f bindings/tcl/pkgIndex.tcl bindings/tcl/tclrrd*.so
rm -f examples/cgi-demo.cgi
rm -rf src/.libs src/.deps doc/*.html doc/*.1 doc/*.txt
diff -u rrdtool-1.4.7/debian/rrdcached.init.d rrdtool-1.4.7/debian/rrdcached.init.d
rrdtool-1.4.7/debian/rrdcached.init.d
+++ rrdtool-1.4.7/debian/rrdcached.init.d
@@ -61,6 +61,10 @@
return 0
fi

+ # make sure we have the needed directories
+ mkdir -p /var/lib/rrdcached/journal/
+ mkdir -p /var/lib/rrdcached/db/
+
start-stop-daemon --start --quiet --oknodo --pidfile "$PIDFILE" \
}
diff -u rrdtool-1.4.7/debian/changelog rrdtool-1.4.7/debian/changelog
rrdtool-1.4.7/debian/changelog
+++ rrdtool-1.4.7/debian/changelog
@@ -1,3 +1,15 @@
+rrdtool (1.4.7-1.2) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fix "fails to install, postinst, invoke-rc.d rrdcached start, start-
+ stop-daemon, segfault":
+ (re-)create /var/lib/rrdcached/{journal,db} in init script.
+ (Closes: #664724)
+ * debian/rules: remove the generated bindings/perl-shared/MYMETA.yml in the
+ clean target.
+
+ -- gregor herrmann <gregoa@debian.org> Sun, 29 Jul 2012 17:35:13 +0200
+
rrdtool (1.4.7-1.1) unstable; urgency=low

* Non-maintainer upload.






To UNSUBSCRIBE, email to debian-bugs-rc-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
email Follow the discussionReplies 3 repliesReplies Make a reply

Similar topics

Replies

#1 owner
July 29th, 2012 - 11:50 am ET | Report spam
Processing commands for :

tags 664724 + patch


Bug #664724 [rrdcached] rrdcached: fails to install, postinst, invoke-rc.d rrdcached start, start-stop-daemon, segfault
Added tag(s) patch.
tags 664724 + pending


Bug #664724 [rrdcached] rrdcached: fails to install, postinst, invoke-rc.d rrdcached start, start-stop-daemon, segfault
Added tag(s) pending.
thanks


Stopping processing here.

Please contact me if you need assistance.
664724: http://bugs.debian.org/cgi-bin/bugr...i?bugf4724
Debian Bug Tracking System
Contact with problems


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#2 Sebastian Harl
August 01st, 2012 - 03:40 am ET | Report spam

Hi Gregor,

On Sun, Jul 29, 2012 at 05:45:16PM +0200, gregor herrmann wrote:
I've prepared an NMU for rrdtool (versioned as 1.4.7-1.2) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.



Thanks for taking care of that!

You fix addresses the problem with the default configuration but it will
fail if the user decides to change the data directory for the RRD files.
Ultimately, this needs to be fixed in RRDCacheD. I'll see if I'm able to
find a fix in time for Wheezy.

Cheers,
Sebastian

Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Replies Reply to this message
#3 gregor herrmann
August 01st, 2012 - 10:50 am ET | Report spam

On Wed, 01 Aug 2012 09:30:33 +0200, Sebastian Harl wrote:

> I've prepared an NMU for rrdtool (versioned as 1.4.7-1.2) and
> uploaded it to DELAYED/2. Please feel free to tell me if I
> should delay it longer.
Thanks for taking care of that!



You're welcome.

You fix addresses the problem with the default configuration but it will
fail if the user decides to change the data directory for the RRD files.



It could be argued that users who change the directory should create
it beforehand :)

Ultimately, this needs to be fixed in RRDCacheD. I'll see if I'm able to
find a fix in time for Wheezy.



Great, thanks; although I'm not convinced this is release-critical
(but that's up to you and the release team of course).


Cheers,
gregor

.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Bettina Wegner: Schlaflied





To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
email Follow the discussion Replies Reply to this message
Help Create a new topicReplies Make a reply
Search Make your own search