[PATCH 00/12 v2] staging: mei: adding new watchdog core support

September 07th, 2011 - 02:10 am ET by Oren Weil | Report spam

In this patches set we are adding the new watchdog core to the mei driver.
Until now the mei driver manage by itself the Intel(R) Active Management Technology
(Intel(R) AMT) watchdog, the driver send the heartbeat by a
internal timer and the internal was defined by module parameter.

for more information about the Intel(R) AMT watchdog read
drivers/staging/mei/mei.txt

Version 2 - Removed two tab indent in patch 05

Oren Weil (12):
staging: mei: removing dependency between WD and AMTHI init function.
staging: mei: fix register access function comments
staging: mei: registering the MEI driver with the kernel watchdog
core interface
staging: mei: adding watchdog ops
staging: mei: adding watchdog ping
staging: mei: adding set_timeout watchdog function
staging: mei: renaming delayed work field and function to a
meaningful name.
staging: mei: resuming timer regardless of the watchdog timeout
value.
stagign: mei: client init code cleanup
staging: mei: removing wd module parameters
staging: mei: adding mei_wd_stop function comment
staging: mei: adding watchdog core dependency to kconfig

drivers/staging/mei/Kconfig | 2 +-
drivers/staging/mei/init.c | 9 ++-
drivers/staging/mei/interface.h | 8 +-
drivers/staging/mei/interrupt.c | 45 +++--
drivers/staging/mei/main.c | 19 ++--
drivers/staging/mei/mei_dev.h | 22 +++-
drivers/staging/mei/wd.c | 242 +++++++++++++++++++++++++++++++++
7 files changed, 261 insertions(+), 86 deletions(-)

1.7.4.1

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow the discussion Replies

12 replies Replies

Make a reply

Replies

#11 Oren Weil

September 07th, 2011 - 02:10 am ET | Report spam

wd module parameter is not needed now that driver is using watchdog core.

Signed-off-by: Oren Weil
Acked-by: Tomas Winkler

drivers/staging/mei/wd.c | 10 -
1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/mei/wd.c b/drivers/staging/mei/wd.c
index fd67952..b56b1cc 100644
a/drivers/staging/mei/wd.c
+++ b/drivers/staging/mei/wd.c
@@ -26,16 +26,6 @@
#include "interface.h"
#include "mei.h"

-/*
- * MEI Watchdog Module Parameters
- */
-static u16 watchdog_timeout = AMT_WD_DEFAULT_TIMEOUT;
-module_param(watchdog_timeout, ushort, 0);
-MODULE_PARM_DESC(watchdog_timeout,
- "Intel(R) AMT Watchdog timeout value in seconds. (default="
- __MODULE_STRING(AMT_WD_DEFAULT_TIMEOUT)
- ", disable=0)");
-
static const u8 mei_start_wd_params[] = { 0x02, 0x12, 0x13, 0x10 };
static const u8 mei_stop_wd_params[] = { 0x02, 0x02, 0x14, 0x10 };

1.7.4.1

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Reply to this message

#12 Oren Weil

September 07th, 2011 - 02:10 am ET | Report spam

From 0d425f09d49b13b0dd8282e946bc87947a20a4a3 Mon Sep 17 00:00:00 2001
From: Oren Weil
Date: Wed, 17 Aug 2011 13:22:12 +0300
Subject: [PATCH 12/12 v2] staging: mei: adding watchdog core dependency to kconfig

Signed-off-by: Oren Weil
Acked-by: Tomas Winkler

drivers/staging/mei/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/mei/Kconfig b/drivers/staging/mei/Kconfig
index 3f3f170..47d78a7 100644
a/drivers/staging/mei/Kconfig
+++ b/drivers/staging/mei/Kconfig
@@ -1,6 +1,6 @@
config INTEL_MEI
tristate "Intel Management Engine Interface (Intel MEI)"
- depends on X86 && PCI && EXPERIMENTAL
+ depends on X86 && PCI && EXPERIMENTAL && WATCHDOG_CORE
help
The Intel Management Engine (Intel ME) provides Manageability,
Security and Media services for system containing Intel chipsets.
1.7.4.1

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow the discussion Replies

Reply to this message

Create a new topic