RFS: ncmpcpp (updated package)

Hi Damien,

Damien Leone wrote:

I am looking for a sponsor for the new version 0.5.10 of my package
"ncmpcpp" [0] (currently uploaded version is 0.5.6).

It builds this binary package:
ncmpcpp - ncurses-based client for the Music Player Daemon (MPD)

The package appears to be lintian clean.

The upload would fix bugs 661858, 667294 and 611467
The package can be found here:
- URL: http://debian.fensalir.fr/ncmpcpp/
- dget http://debian.fensalir.fr/ncmpcpp/n...5.10-1.dsc

I also would like to apologize for taking so long to update this package.

Since I'm the one who was pressing you for a new release, I feel I owe
you at least a review, so here it goes:

- In debian/changelog, you mention updating the standards version, but
not the changes required; if there wasn't any, you should mention
that in the changelog.

Also, the paths to the last two patches are wrong (missing the
"patches" directory).

You could also have sub-items for the "New upstream release" entry,
detailing which bugs are fixed (right now, it looks like the three
bugs are duplicates, and one doesn't know what they correspond to).

- Have you forwarded the patches upstream?

- It would be great if you could use hardening flags [1], as it's a
release goal for wheezy [2]; given the fact that ncmpcpp handles
network data, it seems like a prime candidate.

[1] http://wiki.debian.org/Hardening
[2] http://wiki.debian.org/ReleaseGoals...BuildFlags

Using generic debhelper compat 9 would enable hardening flags
automatically.

- In the man page ncmpcpp(1), CONFIGURATION appears to

Using generic debhelper compat 9 would enable hardening flags
automatically.

- In the man page ncmpcpp(1), CONFIGURATION appears to be a subsection
of OPTIONS, which is probably a mistake.

- Please consider using the DEP-5 format [3] for debian/copyright.

[3] http://www.debian.org/doc/packaging...ormat/1.0/

Thanks for your work on this new package.

Cheers,

Benoît Knecht


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/

Hi Benoît,

Thanks for your review. Comments below:

On Sun, May 13, 2012 at 3:22 AM, Benoît Knecht wrote:

- In debian/changelog, you mention updating the standards version, but
not the changes required; if there wasn't any, you should mention
that in the changelog.

Also, the paths to the last two patches are wrong (missing the
"patches" directory).

You could also have sub-items for the "New upstream release" entry,
detailing which bugs are fixed (right now, it looks like the three
bugs are duplicates, and one doesn't know what they correspond to).

Fixed.

- Have you forwarded the patches upstream?

Not yet, as I would like to get the package uploaded ASAP. But I will
forward to upstream.

- It would be great if you could use hardening flags [1], as it's a
release goal for wheezy [2]; given the fact that ncmpcpp handles
network data, it seems like a prime candidate.

[1] http://wiki.debian.org/Hardening
[2] http://wiki.debian.org/ReleaseGoals...BuildFlags

Using generic debhelper compat 9 would enable hardening flags
automatically.

Fixed by bumping package to debhelper compat 9.

- In the man page ncmpcpp(1), CONFIGURATION appears to be a subsection
of OPTIONS, which is probably a mistake.

Added a patch to fix this.

- Please consider using the DEP-5 format [3] for debian/copyright.

[3] http://www.debian.org/doc/packaging...ormat/1.0/

Fixed. I also updated copyright dates and holders (basically removed some
because grepping their name in the source code didn't give any result
anymore).

Update package available here:
- URL: http://debian.fensalir.fr/ncmpcpp/
- dget http://debian.fensalir.fr/ncmpcpp/n...5.10-1.dsc

Thanks,
Damien


Hi Benoît,<br><br>Thanks for your review. Comments below:<br><br><div class="gmail_quote">On Sun, May 13, 2012 at 3:22 AM, Benoît Knecht <span dir="ltr">&lt;<a href="mailto:" target="_blank"></a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> 
- In debian/changelog, you mention updating the standards version, but<br>
   not the changes required; if there wasn&#39;t any, you should mention<br>
   that in the changelog.<br>
<br>
   Also, the paths to the last two patches are wrong (missing the<br>
   &quot;patches&quot; directory).<br>
<br>
   You could also have sub-items for the &quot;New upstream release&quot; entry,<br>
   detailing which bugs are fixed (right now, it looks like the three<br>
   bugs are duplicates, and one doesn&#39;t know what they correspond to).<br>
<br></blockquote><div><br>Fixed.<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 - Have you forwarded the patches upstream?<br>
<br></blockquote><div><br>Not yet, as I would like to get the package uploaded ASAP. But I will forward to upstream.<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

 - It would be great if you could use hardening flags [1], as it&#39;s a<br>
   release goal for wheezy [2]; given the fact that ncmpcpp handles<br>
   network data, it seems like a prime candidate.<br>
<br>
   [1] <a href="http://wiki.debian.org/Hardening" target="_blank">http://wiki.debian.org/Hardening<...<br>
   [2] <a href="http://wiki.debian.org/ReleaseGoals...lags" target="_blank">http://wiki.debian.org/ReleaseGoals...<br>
<br>
   Using generic debhelper compat 9 would enable hardening flags<br>
   automatically.<br>
<br></blockquote><div><br>Fixed by bumping package to debhelper compat 9. <br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
 - In the man page ncmpcpp(1), CONFIGURATION appears to be a subsection<br>
   of OPTIONS, which is probably a mistake.<br>
<br></blockquote><div><br>Added a patch to fix this.<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 - Please consider using the DEP-5 format [3] for debian/copyright.<br>
<br>
   [3] <a href="http://www.debian.org/doc/packaging...1.0/" target="_blank">http://www.debian.org/doc/packaging...<br>
<br></blockquote><div><br>Fixed. I also updated copyright dates and holders (basically removed some because grepping their name in the source code didn&#39;t give any result anymore).<br></div></div><br>Update package available here:<br>
- URL: <a href="http://debian.fensalir.fr/ncmpcpp/" target="_blank">http://debian.fensalir.fr/ncmpcpp/&...<br>
- dget <a href="http://debian.fensalir.fr/ncmpcpp/n....dsc" target="_blank">http://debian.fensalir.fr/ncmpcpp/n...<br>



To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/CAFzf25n_0E...1yGkg9hyG=