Tags Tags

RFS: vodafone-mobile-broadband

January 07th, 2012 - 07:30 pm ET by Alex Chiang | Report spam
Help Create a new topic
Hello,

I'm looking for both reviews and a sponsor for my package
"vodafone-mobile-broadband". This is a GUI that works in
conjunction with the wader-core package that was recently
accepted into the archive.

To get some idea of what it can do, please check out:
http://postimage.org/gallery/j8hopls/

Any review comments or sponsorship offers would be greatly
appreciated.

licensecheck says there are some missing copyright files;
upstream has added them already in github, but has not yet tagged
a new release with them, as they would prefer to get all the
debian feedback before releasing a new tag.

Get it:
http://mentors.debian.net/package/v...-broadband
dget -x http://mentors.debian.net/debian/po...9.15-1.dsc

Thanks!
/ac

###

* Package name : vodafone-mobile-broadband
Version : 2.99.15
Upstream Author : Andrew Bird <ajb@spheresystems.co.uk>
* URL : https://github.com/andrewbird/vodaf...-broadband
* License : GPL-2+
Programming Lang: Python
Description : GUI for 3G modem SIM card activities
Perform common activities associated with 3G mobile devices and accounts:
- turn 3G internet connection on and off
- send and receive SMS
- manage SIM card PIN
- manage SIM card profiles
- check account data plan usage
- manage contacts (phonebook) stored on SIM card
- purchase additional data from carrier (top up)


To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: http://lists.debian.org/20120108002837.GE3691@canonical.com
email Follow the discussionReplies 5 repliesReplies Make a reply

Similar topics

Replies

#1 Savvas Radevic
January 07th, 2012 - 09:00 pm ET | Report spam
I'm looking for both reviews and a sponsor for my package
"vodafone-mobile-broadband".



Um.. I'm pro free speech and all, but is the programmer (and the
maintainer for that matter) allowed to use "vodafone" in a product and
avoid copyright issues? Unless it is acknowledged by vodafone that is.
(I'm not a debian maintainer)


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/CAP1y3PfwPt...9_OE8rJVC+
Replies Reply to this message
#2 Jakub Wilk
January 07th, 2012 - 09:10 pm ET | Report spam
(I don't intend to sponsor this package.)

* Alex Chiang , 2012-01-07, 16:28:
http://mentors.debian.net/package/v...-broadband
dget -x http://mentors.debian.net/debian/po...9.15-1.dsc



Some aesthetic nitpicking:
- The copyright file mixes tabs with spaces.
- Please add a space between "packaging" and "(" in debian/changelog.

This:
-find . -name '*.py[co]' | xargs rm -f
could be better written as:
find . -name '*.py[co]' -delete

Your clean target runs dh_clean twice.

Lintian emits some informative tags:
I: vodafone-mobile-broadband source: binary-control-field-duplicates-source field "section" in package vodafone-mobile-broadband
I: vodafone-mobile-broadband: package-contains-empty-directory usr/share/vodafone-mobile-broadband/resources/themes/
I: vodafone-mobile-broadband: desktop-entry-contains-encoding-key usr/share/applications/vodafone-mobile-broadband.desktop:2 Encoding

Licence/copyright for resources/tools/FreeSans.ttf is not documented in
the copyright file. Worse still, I believe the font is GPL-ed and TTF
is not the preferred form of modification (for this particular font).
This renders the source package undistributable.

"Remember that this information is only orientative" (in
resources/glade/main.glade) - I think this needs to be rephrased, I
don't believe "orientative" is an English word. :)

Jakub Wilk


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/
Replies Reply to this message
#3 Alex Chiang
January 07th, 2012 - 09:20 pm ET | Report spam
* Savvas Radevic :
> I'm looking for both reviews and a sponsor for my package
> "vodafone-mobile-broadband".

Um.. I'm pro free speech and all, but is the programmer (and the
maintainer for that matter) allowed to use "vodafone" in a product and
avoid copyright issues? Unless it is acknowledged by vodafone that is.
(I'm not a debian maintainer)



As you can see in debian/copyright:

Files: *
Copyright: 2006-2011, Vodafone España S.A.
2008-2009, Warp Networks S.L.
2010, Vodafone Group
License: GPL-2+

This is also the name of the upstream project.

I don't see any issues from upstream's point of view. I wouldn't
think it would be an issue from the Debian point of view, but
welcome a more informed opinion on the matter.

thanks,
/ac


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/
Replies Reply to this message
#4 Charles Plessy
January 08th, 2012 - 02:50 am ET | Report spam
Le Sun, Jan 08, 2012 at 03:05:20AM +0100, Jakub Wilk a écrit :
* Alex Chiang , 2012-01-07, 16:28:
> http://mentors.debian.net/package/v...-broadband
> dget -x http://mentors.debian.net/debian/po...9.15-1.dsc

Licence/copyright for resources/tools/FreeSans.ttf is not documented
in the copyright file. Worse still, I believe the font is GPL-ed and
TTF is not the preferred form of modification (for this particular
font). This renders the source package undistributable.



Note that it would be preferrable to depend on ttf-freefont, that provides this
font, than distributing a copy in vodafone-mobile-broadband.

Have a nice Sunday,

Charles Plessy
Tsurumi, Kanagawa, Japan


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/
Replies Reply to this message
#5 Alex Chiang
January 18th, 2012 - 01:10 pm ET | Report spam
* Jakub Wilk :
* Alex Chiang , 2012-01-07, 16:28:
> http://mentors.debian.net/package/v...-broadband
> dget -x http://mentors.debian.net/debian/po...9.15-1.dsc

[jwilk's review]



Just wanted to follow up and say thank you for the review. We are
still working with Vodafone to see if the package requires a
rename.

thanks,
/ac


To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact
Archive: http://lists.debian.org/
email Follow the discussion Replies Reply to this message
Help Create a new topicReplies Make a reply
Search Make your own search