Bug#652948: mediawiki: Incorrect sidebar rendering with Monobook skin and Firefox 9

Ah, my bad. Chaning someting of this doesn't do anything, because the
second variable says is_ff2_ (mark the undersocre).

It was something other which does the trick, something so trivial I just
forgot:

just change

// special stylesheet links
if (typeof stylepath != 'undefined' && typeof skin != 'undefined') {
if (is_opera_preseven) {
importStylesheetURI(stylepath+'/'+skin+'/Opera6Fixes.css');
} else if (is_opera_seven && !is_opera_95) {
importStylesheetURI(stylepath+'/'+skin+'/Opera7Fixes.css');
} else if (is_opera_95) {
importStylesheetURI(stylepath+'/'+skin+'/Opera9Fixes.css');
} else if (is_khtml) {
importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');
} else if (is_ff2) {
importStylesheetURI(stylepath+'/'+skin+'/FF2Fixes.css');
}
}
/code

to

code-
// special stylesheet links
if (typeof stylepath != 'undefined' && typeof skin != 'undefined') {
if (is_opera_preseven) {
importStylesheetURI(stylepath+'/'+skin+'/Opera6Fixes.css');
} else if (is_opera_seven && !is_opera_95) {
importStylesheetURI(stylepath+'/'+skin+'/Opera7Fixes.css');
} else if (is_opera_95) {
importStylesheetURI(stylepath+'/'+skin+'/Opera9Fixes.css');
} else if (is_ff2) {
importStylesheetURI(stylepath+'/'+skin+'/FF2Fixes.css');
} else if (is_khtml) {
importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');
}
}

Both KHTML and Firefox apparently get identified; hence KHTML first is
checked in the if - else if - else - loop it goes first. After the
change, Firefox get's priority.

To be honest: which notably widespread Browsers are using KHTML
nowadays? So for me this hack works (and now for real :))

Sebastian


Am 10.01.2012 19:56, schrieb Karl Schmidt:

Your fix isn't working for me?

// For accesskeys; note that FF3+ is included here!
var is_ff2 = /firefox\/[2-9]|minefield\/3/.test( clientPC );
> var is_ff2_ = /firefox\/2/.test( clientPC ); <
-/code-

I have:
// For accesskeys; note that FF3+ is included here!
var is_ff2 = /firefox\/[2-9]|minefield\/3/.test( clientPC );
//var is_ff2_ = /firefox\/2/.test( clientPC );
> var is_ff2_ = /firefox\/2/.test( clientPC ); <
-/code-

I got it to work by commenting out both lines - probably breaks
something else at the same time...

I don't have time - but the output of a diff of the stable vs testing
(or sid) version of this file would probably point ot the answer...



Testing with Iceweasel 9.0.1 (iceweasel 9.0.1-1~bpo60+1)

User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20100101
Firefox/9.0.1 Iceweasel/9.0.1

I think the severity level should be important as it causes a "major
effect on the usability of a package" .

systags GmbH
Lindenstraße 169
40233 Düsseldorf
vox: 0211 - 23 70 69 70
fax: 0211 - 49 39 980
http://systags.de

Steuer Nr. 133/5872/1202, USt. ID.: DE 249032067
Amtsgericht Düsseldorf, HRB 54063
Geschàftsführer: Karin Klytta, Lukas Hegemann, Jan Girulat



To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact