Bug#680078: zsnes: Please install high-res PNG icons provided with the sources

July 03rd, 2012 - 08:40 am ET by Fabian Greffrath | Report spam
This is a multi-part MIME message sent by reportbug.


MIME-Version: 1.0

Package: zsnes
Version: 1.510+bz2-3
Severity: minor
Tags: patch

Hi,

I was excited to see that there are four beautiful icons (well, at least in
comparison with debian/zsnes.xpm) in different resolutions shipped in the
src/icons/ directory of the ZSNES sources. Please find attached a patch against
debian/rules to install these icons in the appropriate place so they are picked
up as icons for the zsnes.desktop file.

- Fabian



Debian Release: wheezy/sid
APT prefers testing
APT policy: (901, 'testing'), (501, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages zsnes depends on:
ii libao4 1.1.0-2
ii libc6 2.13-33
ii libgcc1 1:4.7.0-8
ii libgl1-mesa-glx [libgl1] 8.0.3-1
ii libncurses5 5.9-9
ii libpng12-0 1.2.49-1
ii libsdl1.2debian 1.2.15-5
ii libstdc++6 4.7.0-8
ii libtinfo5 5.9-9
ii zlib1g 1:1.2.7.dfsg-13

zsnes recommends no packages.

zsnes suggests no packages.


MIME-Version: 1.0

diff --git a/debian/rules b/debian/rules
index e1a3231..5090080 100755
a/debian/rules
+++ b/debian/rules
@@ -26,6 +26,14 @@ override_dh_clean:
find src/ -type f -name '*.o' -delete
dh_clean

+override_dh_install:
+ dh_install
+ for res in 16 32 48 64; do \
+ mkdir -p debian/zsnes/usr/share/icons/hicolor/$${res}x$${res}/apps; \
+ cp -f src/icons/$${res}x$${res}x32.png \
+ debian/zsnes/usr/share/icons/hicolor/$${res}x$${res}/apps/zsnes.png; \
+ done
+
override_dh_installchangelogs:
dh_installchangelogs docs/readme.txt/history.txt





To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
email Follow the discussionReplies 6 repliesReplies Make a reply

Replies

#1 Etienne Millon
July 03rd, 2012 - 09:00 am ET | Report spam
* Fabian Greffrath [120703 14:41]:
Hi,

I was excited to see that there are four beautiful icons (well, at least in
comparison with debian/zsnes.xpm) in different resolutions shipped in the
src/icons/ directory of the ZSNES sources. Please find attached a patch against
debian/rules to install these icons in the appropriate place so they are picked
up as icons for the zsnes.desktop file.



Hello,

Thanks for the good suggestions to zsnes, this helps. Would you be
interested in co-maintaining this package with us ?

Regarding this particular patch :

+override_dh_install:
+ dh_install
+ for res in 16 32 48 64; do \
+ mkdir -p debian/zsnes/usr/share/icons/hicolor/$${res}x$${res}/apps; \
+ cp -f src/icons/$${res}x$${res}x32.png \
+ debian/zsnes/usr/share/icons/hicolor/$${res}x$${res}/apps/zsnes.png; \
+ done



I believe that adding

src/icons/16x16.png usr/share/icons/hicolor/16x16/apps/zsnes.png

and similar other lines to debian/zsnes.install would be more readable.

Etienne Millon



To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact

Similar topics