Bug#680157: unblock: gcpegg/5.1-13

July 04th, 2012 - 02:00 am ET by Bdale Garbee | Report spam
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gcpegg. This version fixes RC bug #680014 which
affects all 64-bit architectures. It also fixes an unreported path bug
in the init.d script that would affect all users.

This is *not* an absolutely minimal diff to fix those bugs from -12, but
the package is better in all respects, -13 has received significant testing,
and it's a "leaf package" that nothing else depends on... so I really think
5.1-13 is the version that should be in wheezy.

Thanks!

Bdale

unblock gcpegg/5.1-13

Debian Release: wheezy/sid
APT prefers unstable
APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 3.4.4-64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
email Follow the discussionReplies 2 repliesReplies Make a reply

Replies

#1 Julien Cristau
July 04th, 2012 - 12:50 pm ET | Report spam

On Tue, Jul 3, 2012 at 23:48:52 -0600, Bdale Garbee wrote:

Package: release.debian.org
Severity: normal
User:
Usertags: unblock

Please unblock package gcpegg. This version fixes RC bug #680014 which
affects all 64-bit architectures. It also fixes an unreported path bug
in the init.d script that would affect all users.

This is *not* an absolutely minimal diff to fix those bugs from -12, but
the package is better in all respects, -13 has received significant testing,
and it's a "leaf package" that nothing else depends on... so I really think
5.1-13 is the version that should be in wheezy.


diff -u gcpegg-5.1/reg_orion.c gcpegg-5.1/reg_orion.c
gcpegg-5.1/reg_orion.c
+++ gcpegg-5.1/reg_orion.c
@@ -97,7 +97,7 @@
sprintf(ttydev, "/dev/term/%c", 'a' + (opts->port - 1));
#endif
#else
- sprintf(ttydev, "/dev/ttyS%d", opts->port);
+ sprintf(ttydev, "/dev/REG", opts->port);
#endif

switch(opts->baud) {



shouldn't the opts->port argument have been dropped? same in
reg_pear.c, hw_pear.c.

-
- strftime(udate, sizeof udate, timeFormat, gmtime((time_t *) &now));
- strftime(ustime, sizeof ustime, timeFormat, gmtime((time_t *) &upsince));
+
+ now_val = now;
+ strftime(udate, sizeof udate, timeFormat, gmtime(&now_val));
+ time_t upsince_val = upsince;
+ strftime(ustime, sizeof ustime, timeFormat, gmtime(&upsince_val));



funky indent... (and in a bunch of other places)

The hardcoding of vt 8 in the init script feels wrong as well, but I
guess that's not a regression. (It's going to clash with a display
manager that starts before it or in parallel.)

Looks reasonable otherwise.

Cheers,
Julien






To UNSUBSCRIBE, email to
with a subject of "unsubscribe". Trouble? Contact

Similar topics