Tags Tags

[gentoo-dev] [RFC]flag-o-matic.eclass strip-flags change to support prefix

June 17th, 2012 - 08:20 am ET by Maxim Koltsov | Report spam
Help Create a new topic

Hi,
During prefix bootstrap i noticed that strip-flags removes -L and -I
flags from *FLAGS while these flags are essential for prefix
bootstrapping. Therefore i propose a fix for strip-flags function to
make it preserve prefix-related flags. I have attached a patch, please
review it. It works for me, but I'm unsure how it will work with
spaces in ${EPREFIX}

Thanks,
Maxim.

X-Attachment-Id: f_h3k2txoq0

LS0tIGVjbGFzcy9mbGFnLW8tbWF0aWMuZWNsYXNzCTIwMTItMDMtMDQgMDg6MDE6MzIuMDAwMDAw
MDAwICswNDAwCisrKyBlY2xhc3MvZmxhZy1vLW1hdGljLmVjbGFzcwkyMDEyLTA2LTE3IDE2OjA4
OjQ1LjMxNjM0MjQ0NCArMDQwMApAQCAtNTIsNiArNTIsMTEgQEAKIAkjIDQuNgogCUFMTE9XRURf
RkxBR1MrPSIgLW1uby1mc2dzYmFzZSAtbW5vLXJkcm5kIC1tbm8tZjE2YyAtbW5vLWJtaSAtbW5v
LXRibSIKIAorCSNQcmVmaXgKKwlpZiBbWyAiJHtFUFJFRklYfSIgXV07IHRoZW4KKwkJQUxMT1dF
RF9GTEFHUys9IiAtTCR7RVBSRUZJWH0qIC1JJHtFUFJFRklYfSoiCisJZmkKKwogCWV4cG9ydCBB
TExPV0VEX0ZMQUdTCiAJcmV0dXJuIDAKIH0K
email Follow the discussionReplies 8 repliesReplies Make a reply

Replies

#1 Justin
June 17th, 2012 - 08:30 am ET | Report spam
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)

On 17.06.2012 14:13, Maxim Koltsov wrote:
Hi,
During prefix bootstrap i noticed that strip-flags removes -L and -I
flags from *FLAGS while these flags are essential for prefix
bootstrapping. Therefore i propose a fix for strip-flags function to



Is this really necessary? I never experienced any problems which need
this when following the guides. I looks like a hack, because something
else is borked.

make it preserve prefix-related flags. I have attached a patch, please
review it. It works for me, but I'm unsure how it will work with
spaces in ${EPREFIX}



Why not use "use prefix" instead of checking for the variable?





Similar topics

Make your own search :