[PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

April 16th, 2012 - 09:30 pm ET by H Hartley Sweeten | Report spam
Include the linux/mmc/cd-gpio.h header to pickup the prototypes
for the two exported symbols.

This quiets the sparse warnings:

warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>



diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
index 29de31e..da7c3f9 100644
a/drivers/mmc/core/cd-gpio.c
+++ b/drivers/mmc/core/cd-gpio.c
@@ -13,6 +13,7 @@
#include <linux/interrupt.h>
#include <linux/jiffies.h>
#include <linux/mmc/host.h>
+#include <linux/mmc/cd-gpio.h>
#include <linux/module.h>
#include <linux/slab.h>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
email Follow the discussionReplies 2 repliesReplies Make a reply

Replies

#1 Guennadi Liakhovetski
April 17th, 2012 - 03:10 am ET | Report spam
Hi Hartley

Thanks for the patch.

On Mon, 16 Apr 2012, H Hartley Sweeten wrote:

Include the linux/mmc/cd-gpio.h header to pickup the prototypes
for the two exported symbols.

This quiets the sparse warnings:

warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten
Cc: Chris Ball
Cc: Guennadi Liakhovetski



diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
index 29de31e..da7c3f9 100644
a/drivers/mmc/core/cd-gpio.c
+++ b/drivers/mmc/core/cd-gpio.c
@@ -13,6 +13,7 @@
#include <linux/interrupt.h>
#include <linux/jiffies.h>
#include <linux/mmc/host.h>
+#include <linux/mmc/cd-gpio.h>



Call me a pettyfogger, but please put the header above mmc/host.h, please,
keep the alphabetic order.

#include <linux/module.h>
#include <linux/slab.h>




Thanks
Guennadi

Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Similar topics