[PATCH] oom: add uid to "Killed process" message

June 20th, 2011 - 07:10 am ET by Frantisek Hrbata | Report spam
Add user id to the oom killer's "Killed process" message, so the user of the
killed process can be identified.

Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>

mm/oom_kill.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index e4b0991..249a15a 100644
a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -427,8 +427,9 @@ static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
/* mm cannot be safely dereferenced after task_unlock(p) */
mm = p->mm;

- pr_err("Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB",
- task_pid_nr(p), p->comm, K(p->mm->total_vm),
+ pr_err("Killed process %d (%s) uid: %d, total-vm:%lukB, "
+ "anon-rss:%lukB, file-rss:%lukB",
+ task_pid_nr(p), p->comm, task_uid(p), K(p->mm->total_vm),
K(get_mm_counter(p->mm, MM_ANONPAGES)),
K(get_mm_counter(p->mm, MM_FILEPAGES)));
task_unlock(p);
1.7.4.4

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
email Follow the discussionReplies 3 repliesReplies Make a reply

Replies

#1 David Rientjes
June 20th, 2011 - 05:10 pm ET | Report spam
On Mon, 20 Jun 2011, Frantisek Hrbata wrote:

Add user id to the oom killer's "Killed process" message, so the user of the
killed process can be identified.




Notified in what way? Unless you are using the memory controller, there's
no userspace notification that an oom event has happened so nothing would
know to scrape the kernel log for this information.

We've had a long-time desire for an oom notifier, not only at the time of
oom but when approaching it with configurable thresholds, that would
wakeup a userspace daemon that might be polling on notifier. That seems
more useful for realtime notification of an oom event rather than relying
on the kernel log?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Similar topics