[PATCH] perf report: fix compile failure on ppc, 32-bit

May 07th, 2012 - 10:00 pm ET by David Ahern | Report spam
Builds currently fail with:
CC /tmp/pbuild/builtin-report.o
cc1: warnings being treated as errors
builtin-report.c: In function ‘hists__fprintf_nr_sample_events’:
builtin-report.c:307: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘u64’
make: *** [/tmp/pbuild/builtin-report.o] Error 1

$ rpm -q gcc
gcc-4.4.4-10.fc12.ppc

Signed-off-by: David Ahern <dsahern@gmail.com>

tools/perf/builtin-report.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 5df829f..7477655 100644
a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -304,7 +304,7 @@ static size_t hists__fprintf_nr_sample_events(struct hists *self,
if (evname != NULL)
ret += fprintf(fp, " of event '%s'", evname);

- ret += fprintf(fp, "# Event count (approx.): %lu", nr_events);
+ ret += fprintf(fp, "# Event count (approx.): %" PRIu64, nr_events);
return ret + fprintf(fp, "#");
}

1.7.5.4

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
email Follow the discussionReplies 1 replyReplies Make a reply

Replies

#1 Arnaldo Carvalho de Melo
May 08th, 2012 - 09:20 am ET | Report spam
Em Mon, May 07, 2012 at 07:59:22PM -0600, David Ahern escreveu:
Builds currently fail with:
CC /tmp/pbuild/builtin-report.o
cc1: warnings being treated as errors
builtin-report.c: In function ‘hists__fprintf_nr_sample_events’:
builtin-report.c:307: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘u64’
make: *** [/tmp/pbuild/builtin-report.o] Error 1



Jiri sent this, I reproduced it yesterday on an Atom machine, will push
today, thanks,

- Arnaldo

$ rpm -q gcc
gcc-4.4.4-10.fc12.ppc

Signed-off-by: David Ahern

tools/perf/builtin-report.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 5df829f..7477655 100644
a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -304,7 +304,7 @@ static size_t hists__fprintf_nr_sample_events(struct hists *self,
if (evname != NULL)
ret += fprintf(fp, " of event '%s'", evname);

- ret += fprintf(fp, "# Event count (approx.): %lu", nr_events);
+ ret += fprintf(fp, "# Event count (approx.): %" PRIu64, nr_events);
return ret + fprintf(fp, "#");
}

1.7.5.4


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Similar topics